Why not use JFile::getExt($filename) with uploads
Gosling Cools
Junior Member
Posts: 20
9 anos 1 semana atrás #1078
por Gosling Cools
Why not use JFile::getExt($filename) with uploads foi criado por Gosling Cools
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Por favor Acessar ou Registrar para participar da conversa.
Victor
Administrator
Posts: 19
9 anos 5 dias atrás #1079
por Victor
Back-end developer on Component Creator
Respondido por Victor no tópico Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Por favor Acessar ou Registrar para participar da conversa.
Gosling Cools
Junior Member
Posts: 20
9 anos 5 dias atrás #1080
por Gosling Cools
Respondido por Gosling Cools no tópico Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Por favor Acessar ou Registrar para participar da conversa.
Gosling Cools
Junior Member
Posts: 20
9 anos 5 dias atrás #1082
por Gosling Cools
Respondido por Gosling Cools no tópico Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Por favor Acessar ou Registrar para participar da conversa.
Gosling Cools
Junior Member
Posts: 20
9 anos 5 dias atrás #1084
por Gosling Cools
Respondido por Gosling Cools no tópico Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Por favor Acessar ou Registrar para participar da conversa.
Victor
Administrator
Posts: 19
9 anos 5 dias atrás #1086
por Victor
Back-end developer on Component Creator
Respondido por Victor no tópico Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Por favor Acessar ou Registrar para participar da conversa.
Tempo para a criação da página:0.052 segundos