Why not use JFile::getExt($filename) with uploads
Gosling Cools
Navegador Junior
Posts: 20
9 años 3 minutos antes #1078
por Gosling Cools
Why not use JFile::getExt($filename) with uploads Publicado por Gosling Cools
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Victor
Administrador
Posts: 19
8 años 11 meses antes #1079
por Victor
Back-end developer on Component Creator
Respuesta de Victor sobre el tema Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Gosling Cools
Navegador Junior
Posts: 20
8 años 11 meses antes #1080
por Gosling Cools
Respuesta de Gosling Cools sobre el tema Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Gosling Cools
Navegador Junior
Posts: 20
8 años 11 meses antes #1082
por Gosling Cools
Respuesta de Gosling Cools sobre el tema Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Gosling Cools
Navegador Junior
Posts: 20
8 años 11 meses antes #1084
por Gosling Cools
Respuesta de Gosling Cools sobre el tema Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Victor
Administrador
Posts: 19
8 años 11 meses antes #1086
por Victor
Back-end developer on Component Creator
Respuesta de Victor sobre el tema Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Por favor, Identificarse o Crear cuenta para unirse a la conversación.
Tiempo de carga de la página: 0.053 segundos