Why not use JFile::getExt($filename) with uploads
Gosling Cools
Junior Member
Posts: 20
9 Anni 1 Settimana fa #1078
da Gosling Cools
Why not use JFile::getExt($filename) with uploads è stato creato da Gosling Cools
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Si prega Accedi o Crea un account a partecipare alla conversazione.
Victor
Administrator
Posts: 19
9 Anni 1 Settimana fa #1079
da Victor
Back-end developer on Component Creator
Risposta da Victor al topic Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Si prega Accedi o Crea un account a partecipare alla conversazione.
Gosling Cools
Junior Member
Posts: 20
9 Anni 1 Settimana fa #1080
da Gosling Cools
Risposta da Gosling Cools al topic Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Si prega Accedi o Crea un account a partecipare alla conversazione.
Gosling Cools
Junior Member
Posts: 20
9 Anni 1 Settimana fa #1082
da Gosling Cools
Risposta da Gosling Cools al topic Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Si prega Accedi o Crea un account a partecipare alla conversazione.
Gosling Cools
Junior Member
Posts: 20
9 Anni 1 Settimana fa #1084
da Gosling Cools
Risposta da Gosling Cools al topic Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Si prega Accedi o Crea un account a partecipare alla conversazione.
Victor
Administrator
Posts: 19
9 Anni 1 Settimana fa #1086
da Victor
Back-end developer on Component Creator
Risposta da Victor al topic Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Si prega Accedi o Crea un account a partecipare alla conversazione.
Tempo creazione pagina: 0.057 secondi