Why not use JFile::getExt($filename) with uploads
Gosling Cools
Junior Lid
Posts: 20
9 jaren 16 minuten geleden #1078
door Gosling Cools
Why not use JFile::getExt($filename) with uploads werd gestart door Gosling Cools
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Victor
Administrator
Posts: 19
8 jaren 11 maanden geleden #1079
door Victor
Back-end developer on Component Creator
Beantwoord door Victor in topic Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Gosling Cools
Junior Lid
Posts: 20
8 jaren 11 maanden geleden #1080
door Gosling Cools
Beantwoord door Gosling Cools in topic Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Gosling Cools
Junior Lid
Posts: 20
8 jaren 11 maanden geleden #1082
door Gosling Cools
Beantwoord door Gosling Cools in topic Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Gosling Cools
Junior Lid
Posts: 20
8 jaren 11 maanden geleden #1084
door Gosling Cools
Beantwoord door Gosling Cools in topic Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Victor
Administrator
Posts: 19
8 jaren 11 maanden geleden #1086
door Victor
Back-end developer on Component Creator
Beantwoord door Victor in topic Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Gelieve Inloggen of een account aanmaken om deel te nemen aan het gesprek.
Tijd voor maken pagina: 0.052 seconden