Why not use JFile::getExt($filename) with uploads
Gosling Cools
Junior Member
Posts: 20
8 года 11 мес. назад #1078
от Gosling Cools
Gosling Cools создал тему: Why not use JFile::getExt($filename) with uploads
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Victor
Administrator
Posts: 19
8 года 11 мес. назад #1079
от Victor
Back-end developer on Component Creator
Victor ответил в теме Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Gosling Cools
Junior Member
Posts: 20
8 года 11 мес. назад #1080
от Gosling Cools
Gosling Cools ответил в теме Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Gosling Cools
Junior Member
Posts: 20
8 года 11 мес. назад #1082
от Gosling Cools
Gosling Cools ответил в теме Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Gosling Cools
Junior Member
Posts: 20
8 года 11 мес. назад #1084
от Gosling Cools
Gosling Cools ответил в теме Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Victor
Administrator
Posts: 19
8 года 11 мес. назад #1086
от Victor
Back-end developer on Component Creator
Victor ответил в теме Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Пожалуйста Войти или Регистрация, чтобы присоединиться к беседе.
Время создания страницы: 0.056 секунд