Why not use JFile::getExt($filename) with uploads

Gosling Cools

Junior Member

Posts: 20

9 år 3 veckor sedan #1078 av Gosling Cools

Why not use JFile::getExt($filename) with uploads skapades av Gosling Cools

Hi,

Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:

//Replace any special characters in the filename
                  $filename = explode('.', $file['name']);
                  $filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);

Regards,

Gosling

Be Logga in eller Skapa ett konto ansluta till konversationen.

Victor

Administrator

Posts: 19

9 år 2 veckor sedan #1079 av Victor

Svar från Victor i ämnet Why not use JFile::getExt($filename) with uploads

Hi Gosling,

Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.

Best regards,

Víctor

Back-end developer on Component Creator

Be Logga in eller Skapa ett konto ansluta till konversationen.

Gosling Cools

Junior Member

Posts: 20

9 år 2 veckor sedan #1080 av Gosling Cools

Svar från Gosling Cools i ämnet Why not use JFile::getExt($filename) with uploads

Thanks!

But now there's an error in the code.

This line:

$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);

Should be

$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);

And this line:

$filename = md5(time()) . '-' . array($filename, '.', $extension);

Shoud/could be:

$filename = md5(time()) . '_' . $filename . '.' . $extension;

Regards,

Gosling

Be Logga in eller Skapa ett konto ansluta till konversationen.

Gosling Cools

Junior Member

Posts: 20

9 år 2 veckor sedan #1082 av Gosling Cools

Svar från Gosling Cools i ämnet Why not use JFile::getExt($filename) with uploads

And now remove the last ) please in:

//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);

Be Logga in eller Skapa ett konto ansluta till konversationen.

Gosling Cools

Junior Member

Posts: 20

9 år 2 veckor sedan #1084 av Gosling Cools

Svar från Gosling Cools i ämnet Why not use JFile::getExt($filename) with uploads

this line:

$filename = md5(time() . '-' . $filename . '.' . $extension);

should be

$filename = md5(time()) . '-' . $filename . '.' . $extension;

Be Logga in eller Skapa ett konto ansluta till konversationen.

Victor

Administrator

Posts: 19

9 år 2 veckor sedan #1086 av Victor

Svar från Victor i ämnet Why not use JFile::getExt($filename) with uploads

Done!

Back-end developer on Component Creator

Be Logga in eller Skapa ett konto ansluta till konversationen.

Sidan laddades på: 0.052 sekunder