Why not use JFile::getExt($filename) with uploads
Gosling Cools
Junior Member
Posts: 20
9 years 4 weeks ago #1078
by Gosling Cools
Why not use JFile::getExt($filename) with uploads was created by Gosling Cools
Hi,
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:Regards,
Gosling
Is there a reason why you don't use JFile::getExt($filename) and JFile::stripExt($filename) in the \tables\XXXXX.php files?
For instance a filename with multiple dots will explode wrongly with your code:
//Replace any special characters in the filename
$filename = explode('.', $file['name']);
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename[0]);
Gosling
Please Log in or Create an account to join the conversation.
Victor
Administrator
Posts: 19
9 years 3 weeks ago #1079
by Victor
Back-end developer on Component Creator
Replied by Victor on topic Why not use JFile::getExt($filename) with uploads
Hi Gosling,
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Thank you for pointing out this issue. We have patched our system to use Joomla functions instead of PHP ones.
Best regards,
Víctor
Back-end developer on Component Creator
Please Log in or Create an account to join the conversation.
Gosling Cools
Junior Member
Posts: 20
9 years 3 weeks ago #1080
by Gosling Cools
Replied by Gosling Cools on topic Why not use JFile::getExt($filename) with uploads
Thanks!
But now there's an error in the code.
This line:Should be
And this line:Shoud/could be:Regards,
Gosling
But now there's an error in the code.
This line:
$filename[0] = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
$filename = preg_replace("/[^A-Za-z0-9]/i", "-", $filename);
And this line:
$filename = md5(time()) . '-' . array($filename, '.', $extension);
$filename = md5(time()) . '_' . $filename . '.' . $extension;
Gosling
Please Log in or Create an account to join the conversation.
Gosling Cools
Junior Member
Posts: 20
9 years 3 weeks ago #1082
by Gosling Cools
Replied by Gosling Cools on topic Why not use JFile::getExt($filename) with uploads
And now remove the last ) please in:
//Add Timestamp MD5 to avoid overwriting
$filename = md5(time()) . '-' . $filename . '.' . $extension);
Please Log in or Create an account to join the conversation.
Gosling Cools
Junior Member
Posts: 20
9 years 3 weeks ago #1084
by Gosling Cools
Replied by Gosling Cools on topic Why not use JFile::getExt($filename) with uploads
this line:should be
$filename = md5(time() . '-' . $filename . '.' . $extension);
$filename = md5(time()) . '-' . $filename . '.' . $extension;
Please Log in or Create an account to join the conversation.
Victor
Administrator
Posts: 19
9 years 3 weeks ago #1086
by Victor
Back-end developer on Component Creator
Replied by Victor on topic Why not use JFile::getExt($filename) with uploads
Done!
Back-end developer on Component Creator
Please Log in or Create an account to join the conversation.
Time to create page: 0.054 seconds